Wallpaper: delay service initialization until settings are ready

Commons/Settings.qml

@@ -89,18 +89,16 @@ Singleton {
       reload()
     }
     onLoaded: function () {
-      Qt.callLater(function () {
+      if (!isLoaded) {
-        // Some stuff like settings validation should just be executed once on startup and not on every reload
+        Logger.log("Settings", "----------------------------")
-        if (!isLoaded) {
+        Logger.log("Settings", "Settings loaded successfully")
-          Logger.log("Settings", "JSON completed loading")
+        isLoaded = true
 
-          // Validate monitor configurations, only once
+        Qt.callLater(function () {
-          // if none of the configured monitors exist, clear the lists
+          // Some stuff like settings validation should just be executed once on startup and not on every reload
           validateMonitorConfigurations()
-
+        })
-          isLoaded = true
+      }
-        }
-      })
     }
     onLoadFailed: function (error) {
       if (error.toString().includes("No such file") || error === 2)

Modules/Background/Background.qml

@@ -10,9 +10,8 @@ Variants {
   delegate: Loader {
 
     required property ShellScreen modelData
-    property string wallpaperSource: WallpaperService.getWallpaper(modelData.name)
 
-    active: wallpaperSource !== ""
+    active: Settings.isLoaded && WallpaperService.getWallpaper(modelData.name)
 
     sourceComponent: PanelWindow {
 
@@ -32,7 +31,7 @@ Variants {
       Image {
         anchors.fill: parent
         fillMode: Image.PreserveAspectCrop
-        source: wallpaperSource
+        source: WallpaperService.getWallpaper(modelData.name)
         cache: true
         smooth: true
         mipmap: false

Modules/Background/Overview.qml

@@ -11,9 +11,8 @@ Variants {
 
   delegate: Loader {
     required property ShellScreen modelData
-    property string wallpaperSource: WallpaperService.getWallpaper(modelData.name)
 
-    active: CompositorService.isNiri && wallpaperSource !== ""
+    active: Settings.isLoaded && CompositorService.isNiri
 
     sourceComponent: PanelWindow {
       Component.onCompleted: {
@@ -37,7 +36,7 @@ Variants {
         id: bgImage
         anchors.fill: parent
         fillMode: Image.PreserveAspectCrop
-        source: wallpaperSource
+        source: WallpaperService.getWallpaper(modelData.name)
         cache: true
         smooth: true
         mipmap: false

Services/MatugenService.qml

@@ -22,7 +22,6 @@ Singleton {
     // Ensure cache dir exists
     Quickshell.execDetached(["mkdir", "-p", Settings.cacheDir])
 
-
     // TODO: fix matugen
     var content = buildConfigToml()
     var mode = Settings.data.colorSchemes.darkMode ? "dark" : "light"