From 9a9f2886e054d1bd2d71d192ce8080e44e83e6a6 Mon Sep 17 00:00:00 2001 From: LemmyCook Date: Sat, 13 Sep 2025 15:23:27 -0400 Subject: [PATCH] Floating Bar: Fix for #265 (overlapping panels, toasts and notifications) --- Modules/Notification/Notification.qml | 4 ++-- Modules/Toast/ToastOverlay.qml | 4 ++-- Widgets/NPanel.qml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Modules/Notification/Notification.qml b/Modules/Notification/Notification.qml index f462a41..c51c043 100644 --- a/Modules/Notification/Notification.qml +++ b/Modules/Notification/Notification.qml @@ -37,8 +37,8 @@ Variants { anchors.top: Settings.data.bar.position === "top" anchors.bottom: Settings.data.bar.position === "bottom" anchors.right: true - margins.top: Settings.data.bar.position === "top" ? (Style.barHeight + Style.marginM + (Settings.data.bar.floating ? Settings.data.bar.marginTop : 0)) * scaling : 0 - margins.bottom: Settings.data.bar.position === "bottom" ? (Style.barHeight + Style.marginM + (Settings.data.bar.floating ? Settings.data.bar.marginBottom : 0)) * scaling : 0 + margins.top: Settings.data.bar.position === "top" ? (Style.barHeight + Style.marginM + (Settings.data.bar.floating ? Settings.data.bar.marginVertical : 0)) * scaling : 0 + margins.bottom: Settings.data.bar.position === "bottom" ? (Style.barHeight + Style.marginM + (Settings.data.bar.floating ? Settings.data.bar.marginVertical : 0)) * scaling : 0 margins.right: Style.marginM * scaling implicitWidth: 360 * scaling implicitHeight: Math.min(notificationStack.implicitHeight, (NotificationService.maxVisible * 120) * scaling) diff --git a/Modules/Toast/ToastOverlay.qml b/Modules/Toast/ToastOverlay.qml index edc9249..32dd3fe 100644 --- a/Modules/Toast/ToastOverlay.qml +++ b/Modules/Toast/ToastOverlay.qml @@ -43,8 +43,8 @@ Variants { implicitHeight: Math.round(toast.visible ? toast.height + Style.marginM * scaling : 1) // Set margins based on bar position - margins.top: Settings.data.bar.position === "top" ? (Style.barHeight + Style.marginS + (Settings.data.bar.floating ? Settings.data.bar.marginTop : 0)) * scaling : 0 - margins.bottom: Settings.data.bar.position === "bottom" ? (Style.barHeight + Style.marginS + (Settings.data.bar.floating ? Settings.data.bar.marginBottom : 0)) * scaling : 0 + margins.top: Settings.data.bar.position === "top" ? (Style.barHeight + Style.marginS + (Settings.data.bar.floating ? Settings.data.bar.marginVertical: 0)) * scaling : 0 + margins.bottom: Settings.data.bar.position === "bottom" ? (Style.barHeight + Style.marginS + (Settings.data.bar.floating ? Settings.data.bar.marginVertical : 0)) * scaling : 0 // Transparent background color: Color.transparent diff --git a/Widgets/NPanel.qml b/Widgets/NPanel.qml index 9b1904e..bf50e5f 100644 --- a/Widgets/NPanel.qml +++ b/Widgets/NPanel.qml @@ -184,8 +184,8 @@ Loader { anchors.left: true anchors.right: true anchors.bottom: true - margins.top: (barIsVisible && !barAtBottom) ? (barHeight + ((Settings.data.bar.floating && !panelAnchorVerticalCenter) ? Settings.data.bar.marginTop : 0)) : 0 - margins.bottom: (barIsVisible && barAtBottom) ? (barHeight + ((Settings.data.bar.floating && !panelAnchorVerticalCenter) ? Settings.data.bar.marginBottom : 0)) : 0 + margins.top: (barIsVisible && !barAtBottom) ? (barHeight + ((Settings.data.bar.floating && !panelAnchorVerticalCenter) ? Settings.data.bar.marginVertical : 0)) : 0 + margins.bottom: (barIsVisible && barAtBottom) ? (barHeight + ((Settings.data.bar.floating && !panelAnchorVerticalCenter) ? Settings.data.bar.marginVertical : 0)) : 0 // Close any panel with Esc without requiring focus Shortcut {