never/noctalia-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix applauncher given 'ABSURDs' recommendations

Browse source
This commit is contained in:
ly-sec 2025-07-11 23:40:07 +02:00
parent fdc3cb3745
commit 95b24a3fe1
10 changed files with 54 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Widgets/Sidebar/Panel/Music.qml
View file

@ -17,7 +17,7 @@ Rectangle {
property real currentPosition: 0
property int selectedPlayerIndex: 0
// Get all available players
// Returns available MPRIS players
function getAvailablePlayers() {
if (!Mpris.players || !Mpris.players.values) {
return []
@ -36,7 +36,7 @@ Rectangle {
return controllablePlayers
}
// Find the active player
// Returns active player or first available
function findActivePlayer() {
let availablePlayers = getAvailablePlayers()
if (availablePlayers.length === 0) {
@ -52,7 +52,7 @@ Rectangle {
}
}
// Update current player
// Updates currentPlayer and currentPosition
function updateCurrentPlayer() {
let newPlayer = findActivePlayer()
if (newPlayer !== currentPlayer) {
@ -61,7 +61,7 @@ Rectangle {
}
}
// Timer to update progress bar position
// Updates progress bar every second
Timer {
id: positionTimer
interval: 1000
@ -74,7 +74,7 @@ Rectangle {
}
}
// Monitor for player changes
// Reacts to player list changes
Connections {
target: Mpris.players
function onValuesChanged() {
@ -92,7 +92,7 @@ Rectangle {
color: Theme.surface
radius: 18
// No music player available state
// Show fallback UI if no player is available
Item {
width: parent.width
height: parent.height
@ -120,25 +120,25 @@ Rectangle {
}
}
// Music player content
// Main player UI
ColumnLayout {
anchors.fill: parent
anchors.margins: 18
spacing: 12
visible: currentPlayer
// Album artwork and track info row
// Album art and spectrum
RowLayout {
spacing: 12
Layout.fillWidth: true
// Album artwork with circular spectrum visualizer, aligned left
// Album art with spectrum
Item {
id: albumArtContainer
width: 96; height: 96 // enough for spectrum and art (will adjust if needed)
Layout.alignment: Qt.AlignLeft | Qt.AlignVCenter
// Circular spectrum visualizer behind album art
// Spectrum visualizer
CircularSpectrum {
id: spectrum
anchors.centerIn: parent
@ -150,7 +150,7 @@ Rectangle {
z: 0
}
// Album art in the center
// Album art image
Rectangle {
id: albumArtwork
width: 60; height: 60
@ -186,7 +186,7 @@ Rectangle {
}
}
// Fallback music icon
// Fallback icon
Text {
anchors.centerIn: parent
text: "album"
@ -198,7 +198,7 @@ Rectangle {
}
}
// Track info
// Track metadata
ColumnLayout {
Layout.fillWidth: true
spacing: 4

5
Widgets/Sidebar/Panel/PanelPopup.qml
View file

@ -30,8 +30,6 @@ PanelWindow {
slideAnim.from = width;
slideAnim.to = 0;
slideAnim.running = true;
// Start system monitoring when sidebar becomes visible
if (systemMonitor) systemMonitor.startMonitoring();
if (weather) weather.startWeatherFetch();
if (systemWidget) systemWidget.panelVisible = true;
@ -57,8 +55,7 @@ PanelWindow {
onStopped: {
if (panelPopup.slideOffset === panelPopup.width) {
panelPopup.visible = false;
// Stop system monitoring when sidebar becomes hidden
// Stop monitoring and background tasks when hidden
if (systemMonitor) systemMonitor.stopMonitoring();
if (weather) weather.stopWeatherFetch();
if (systemWidget) systemWidget.panelVisible = false;

5
Widgets/Sidebar/Panel/QuickAccess.qml
View file

@ -167,14 +167,13 @@ Rectangle {
// Timer to check if recording is active
Timer {
interval: 2000 // Check every 2 seconds
interval: 2000
repeat: true
running: panelVisible
onTriggered: checkRecordingStatus()
}
function checkRecordingStatus() {
// Simple check - if we're recording but no process, reset state
if (isRecording) {
checkRecordingProcess.running = true
}
@ -186,8 +185,6 @@ Rectangle {
command: ["pgrep", "-f", "gpu-screen-recorder.*portal"]
onExited: function(exitCode, exitStatus) {
var isActuallyRecording = exitCode === 0
// If we think we're recording but process isn't running, reset state
if (isRecording && !isActuallyRecording) {
recordingStateMismatch(isActuallyRecording)
}

26
Widgets/Sidebar/Panel/System.qml
View file

@ -26,19 +26,19 @@ Rectangle {
anchors.margins: 18
spacing: 12
// User Info Row
// User info row
RowLayout {
Layout.fillWidth: true
spacing: 12
// Profile Image
// Profile image
Rectangle {
width: 48
height: 48
radius: 24
color: Theme.accentPrimary
// Border overlay
// Border
Rectangle {
anchors.fill: parent
color: "transparent"
@ -82,7 +82,7 @@ Rectangle {
}
}
// User Info
// User info text
ColumnLayout {
spacing: 4
Layout.fillWidth: true
@ -101,12 +101,12 @@ Rectangle {
}
}
// Spacer to push button to the right
// Spacer
Item {
Layout.fillWidth: true
}
// System Menu Button - positioned all the way to the right
// System menu button
Rectangle {
id: systemButton
width: 32
@ -137,7 +137,7 @@ Rectangle {
}
}
// System Menu Popup - positioned below the button
// System menu popup
Rectangle {
id: systemMenu
width: 160
@ -149,7 +149,7 @@ Rectangle {
visible: false
z: 9999
// Position relative to the system button using absolute positioning
// Position below system button
x: systemButton.x + systemButton.width - width + 12
y: systemButton.y + systemButton.height + 32
@ -158,7 +158,7 @@ Rectangle {
anchors.margins: 8
spacing: 4
// Lock Button
// Lock button
Rectangle {
Layout.fillWidth: true
Layout.preferredHeight: 36
@ -196,7 +196,7 @@ Rectangle {
}
}
// Reboot Button
// Reboot button
Rectangle {
Layout.fillWidth: true
Layout.preferredHeight: 36
@ -234,7 +234,7 @@ Rectangle {
}
}
// Logout Button
// Logout button
Rectangle {
Layout.fillWidth: true
Layout.preferredHeight: 36
@ -272,7 +272,7 @@ Rectangle {
}
}
// Shutdown Button
// Shutdown button
Rectangle {
Layout.fillWidth: true
Layout.preferredHeight: 36
@ -356,8 +356,6 @@ Rectangle {
}
Component.onCompleted: {
// Don't update system info immediately - wait for panel to be visible
// updateSystemInfo() will be called when panelVisible becomes true
uptimeProcess.running = true
}

1
Widgets/Sidebar/Panel/SystemMonitor.qml
View file

@ -16,7 +16,6 @@ Rectangle {
property real diskUsage: 0
property bool isVisible: false
// Timers to control when processes run
Timer {
id: cpuTimer
interval: 2000

1
Widgets/Sidebar/Panel/WallpaperPanel.qml
View file

@ -24,7 +24,6 @@ PanelWindow {
command: ["ls", Settings.wallpaperFolder !== undefined ? Settings.wallpaperFolder : ""]
stdout: StdioCollector {
onStreamFinished: {
// Split by newlines and filter out empty lines
wallpaperPanelModal.wallpapers = this.text.split("\n").filter(function(x){return x.length > 0})
}
}

13
Widgets/Sidebar/Panel/Weather.qml
View file

@ -59,12 +59,12 @@ Rectangle {
spacing: 12
Layout.fillWidth: true
// Weather icon and basic info
// Weather icon and basic info section
RowLayout {
spacing: 12
Layout.preferredWidth: 140
// Material Symbol icon
// Weather icon
Text {
id: weatherIcon
text: weatherData && weatherData.current_weather ? materialSymbolForCode(weatherData.current_weather.weathercode) : "cloud"
@ -116,7 +116,7 @@ Rectangle {
Layout.bottomMargin: 2
}
// 5-day forecast row (smaller)
// 5-day forecast row
RowLayout {
spacing: 12
Layout.fillWidth: true
@ -129,7 +129,7 @@ Rectangle {
spacing: 2
Layout.alignment: Qt.AlignHCenter
Text {
// Day name (e.g., Mon)
// Day of the week (e.g., Mon)
text: Qt.formatDateTime(new Date(weatherData.daily.time[index]), "ddd")
font.pixelSize: 12
color: Theme.textSecondary
@ -157,7 +157,7 @@ Rectangle {
}
}
// Error message (if any)
// Error message
Text {
text: errorString
color: Theme.error
@ -169,9 +169,8 @@ Rectangle {
}
}
// Weather code to Material Symbol ligature
// Weather code to Material Symbol ligature mapping
function materialSymbolForCode(code) {
// Open-Meteo WMO code mapping
if (code === 0) return "sunny"; // Clear
if (code === 1 || code === 2) return "partly_cloudy_day"; // Mainly clear/partly cloudy
if (code === 3) return "cloud"; // Overcast

11
Widgets/Sidebar/Panel/WifiPanel.qml
View file

@ -18,7 +18,7 @@ Item {
}
function signalIcon(signal) {
if (signal >= 80) return "network_wifi";
if (signal >= 80) return "network_wifi_4_bar";
if (signal >= 60) return "network_wifi_3_bar";
if (signal >= 40) return "network_wifi_2_bar";
if (signal >= 20) return "network_wifi_1_bar";
@ -69,7 +69,7 @@ Item {
property string connectStatusSsid: ""
property string connectError: ""
property string connectSecurity: ""
property var pendingConnect: null // store connect params for after delete
property var pendingConnect: null
property string detectedInterface: ""
property var connectionsToDelete: []
@ -112,7 +112,7 @@ Item {
}
}
// Disconnect, then delete the profile. This chain is triggered by clicking the row.
// Disconnect, delete profile, refresh
Process {
id: disconnectProfileProcess
property string connectionName: ""
@ -120,7 +120,6 @@ Item {
command: ["nmcli", "connection", "down", "id", connectionName]
onRunningChanged: {
if (!running) {
// After disconnect, delete the profile
deleteProfileProcess.connectionName = connectionName;
deleteProfileProcess.running = true;
}
@ -164,6 +163,7 @@ Item {
}
}
// Handles connecting to a Wi-Fi network, with or without password
Process {
id: connectProcess
property string ssid: ""
@ -202,6 +202,7 @@ Item {
}
}
// Finds the correct Wi-Fi interface for connection
Process {
id: getInterfaceProcess
running: false
@ -235,6 +236,7 @@ Item {
}
}
// Adds a new Wi-Fi connection profile
Process {
id: addConnectionProcess
property string ifname: ""
@ -267,6 +269,7 @@ Item {
}
}
// Brings up the new connection profile and finalizes connection state
Process {
id: upConnectionProcess
property string profileName: ""