never/noctalia-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #63 from quadbyte/brightness-conditional

Browse source 
Brightness indicator is not shown if brightness < 0
This commit is contained in:
Lysec 2025-07-31 23:42:08 +02:00 • committed by GitHub
commit 8c2df56fb5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Bar/Bar.qml
View file

@ -1,4 +1,5 @@
import QtQuick
import QtQuick.Controls
import QtQuick.Layouts
import Quickshell
import Quickshell.Io
@ -8,11 +9,10 @@ import qs.Bar.Modules
import qs.Settings
import qs.Services
import qs.Components
import qs.Helpers
import qs.Widgets
import qs.Widgets.Sidebar
import qs.Widgets.Sidebar.Panel
import qs.Helpers
import QtQuick.Controls
import qs.Widgets.Notification
Scope {
@ -87,6 +87,18 @@ Scope {
anchors.rightMargin: 18
spacing: 12
SystemTray {
id: systemTrayModule
shell: rootScope.shell
anchors.verticalCenter: parent.verticalCenter
bar: panel
trayMenu: externalTrayMenu
}
CustomTrayMenu {
id: externalTrayMenu
}
NotificationIcon {
anchors.verticalCenter: parent.verticalCenter
}
@ -107,18 +119,6 @@ Scope {
anchors.verticalCenter: parent.verticalCenter
}
SystemTray {
id: systemTrayModule
shell: rootScope.shell
anchors.verticalCenter: parent.verticalCenter
bar: panel
trayMenu: externalTrayMenu
}
CustomTrayMenu {
id: externalTrayMenu
}
ClockWidget {
screen: modelData
anchors.verticalCenter: parent.verticalCenter

13
Bar/Modules/Brightness.qml
View file

@ -21,19 +21,24 @@ Item {
Process {
id: getBrightnessProcess
command: [Quickshell.shellDir + "/Programs/zigbrightness", "get", monitorName]
stdout: StdioCollector {
onStreamFinished: {
const output = this.text.trim()
const val = parseInt(output)
if (!isNaN(val) && val >= 0 && val !== previousBrightness) {
if (isNaN(val)) return
if (val < 0) {
brightnessDisplay.visible = false
}
else if (val >= 0 && val !== previousBrightness) {
brightnessDisplay.visible = true
previousBrightness = brightness
brightness = val
pill.text = brightness + "%"
if (firstChange) {
firstChange = false;
firstChange = false
}
else {
pill.show()