From a8244cde67d64f3cca0c0dca01cfc5a94cfe2f8d Mon Sep 17 00:00:00 2001 From: Anas Khalifa Date: Sun, 20 Jul 2025 11:18:20 +0300 Subject: [PATCH 1/4] fix some deprecations --- Services/Sysinfo.qml | 2 +- Services/WallpaperManager.qml | 2 +- Widgets/Sidebar/Panel/System.qml | 5 +++++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Services/Sysinfo.qml b/Services/Sysinfo.qml index 9a168c3..521e768 100644 --- a/Services/Sysinfo.qml +++ b/Services/Sysinfo.qml @@ -23,7 +23,7 @@ Singleton { Process { id: zigstatProcess running: true - command: [Quickshell.shellRoot + "/Programs/zigstat", updateInterval] + command: [Quickshell.shellDir + "/Programs/zigstat", updateInterval] stdout: SplitParser { onRead: function (line) { try { diff --git a/Services/WallpaperManager.qml b/Services/WallpaperManager.qml index 84c0e4f..f32f72c 100644 --- a/Services/WallpaperManager.qml +++ b/Services/WallpaperManager.qml @@ -116,7 +116,7 @@ Singleton { Process { id: generateThemeProcess command: ["wallust", "run", currentWallpaper, "-u", "-k", "-d", "Templates"] - workingDirectory: Quickshell.configDir + workingDirectory: Quickshell.shellDir running: false } } diff --git a/Widgets/Sidebar/Panel/System.qml b/Widgets/Sidebar/Panel/System.qml index c128996..de59e7d 100644 --- a/Widgets/Sidebar/Panel/System.qml +++ b/Widgets/Sidebar/Panel/System.qml @@ -60,6 +60,11 @@ Rectangle { cache: false sourceSize.width: 44 sourceSize.height: 44 + onStatusChanged: { + if (status === Image.Error) { + avatarImage.visible = false; + } + } } maskSource: Rectangle { width: 44 From 3292b53d49437213935d7cc2808f001a7fe85dee Mon Sep 17 00:00:00 2001 From: Anas Khalifa Date: Sun, 20 Jul 2025 12:03:52 +0300 Subject: [PATCH 2/4] Fix battery percentage calculation and make it not show if no battery i detected --- Bar/Modules/Battery.qml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Bar/Modules/Battery.qml b/Bar/Modules/Battery.qml index 49b3eb3..fe66910 100644 --- a/Bar/Modules/Battery.qml +++ b/Bar/Modules/Battery.qml @@ -6,9 +6,10 @@ import qs.Components Item { id: batteryWidget + property var battery: UPower.displayDevice property bool isReady: battery && battery.ready && battery.isLaptopBattery && battery.isPresent - property real percent: isReady ? battery.percentage : 0 + property real percent: isReady ? (battery.percentage * 100) : 0 property bool charging: isReady ? battery.state === UPowerDeviceState.Charging : false property bool show: isReady && percent > 0 @@ -24,7 +25,7 @@ Item { return "battery_alert"; } - visible: show + visible: isReady && battery.isLaptopBattery width: 22 height: 36 @@ -78,4 +79,4 @@ Item { targetItem: batteryWidget delay: 200 } -} \ No newline at end of file +} \ No newline at end of file From e58193f65385b2c0c730f252f65cf37aafb5e6f4 Mon Sep 17 00:00:00 2001 From: Anas Khalifa Date: Sun, 20 Jul 2025 12:12:52 +0300 Subject: [PATCH 3/4] change the signal name to fix Duplicate signal name: invalid override of property change signal or superclass signal --- Bar/Modules/AudioDeviceSelector.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Bar/Modules/AudioDeviceSelector.qml b/Bar/Modules/AudioDeviceSelector.qml index 79ed497..d57ca53 100644 --- a/Bar/Modules/AudioDeviceSelector.qml +++ b/Bar/Modules/AudioDeviceSelector.qml @@ -7,7 +7,7 @@ import qs.Settings PanelWithOverlay { id: ioSelector - signal closed() + signal panelClosed() property int tabIndex: 0 property Item anchorItem: null From b33bcf8eda23c13722c7d5e300ff9ee79544e762 Mon Sep 17 00:00:00 2001 From: Anas Khalifa Date: Sun, 20 Jul 2025 12:16:43 +0300 Subject: [PATCH 4/4] revert unnessary --- Widgets/Sidebar/Panel/System.qml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Widgets/Sidebar/Panel/System.qml b/Widgets/Sidebar/Panel/System.qml index de59e7d..c128996 100644 --- a/Widgets/Sidebar/Panel/System.qml +++ b/Widgets/Sidebar/Panel/System.qml @@ -60,11 +60,6 @@ Rectangle { cache: false sourceSize.width: 44 sourceSize.height: 44 - onStatusChanged: { - if (status === Image.Error) { - avatarImage.visible = false; - } - } } maskSource: Rectangle { width: 44