Fix ArchUpdater error codes, revert TrayMenu

TrayMenu: reverted it to the old PopupPanel for ignored
ArchUpdater: paru error code 1 = no updates available

Modules/Bar/Widgets/Tray.qml

@@ -14,7 +14,7 @@ Rectangle {
   id: root
 
   property ShellScreen screen
-  property real scaling: screen ? ScalingService.scale(screen) : 1.0
+  property real scaling: ScalingService.scale(screen)
   readonly property real itemSize: 24 * scaling
 
   visible: SystemTray.items.values.length > 0
@@ -80,42 +80,35 @@ Rectangle {
 
                        if (mouse.button === Qt.LeftButton) {
                          // Close any open menu first
-                         var trayMenuPanel = PanelService.getPanel("trayMenu")
-                         if (trayMenuPanel && trayMenuPanel.active) {
-                           trayMenuPanel.close()
-                         }
+                         trayPanel.close()
 
                          if (!modelData.onlyMenu) {
                            modelData.activate()
                          }
                        } else if (mouse.button === Qt.MiddleButton) {
                          // Close any open menu first
-                         var trayMenuPanel = PanelService.getPanel("trayMenu")
-                         if (trayMenuPanel && trayMenuPanel.active) {
-                           trayMenuPanel.close()
-                         }
+                         trayPanel.close()
 
                          modelData.secondaryActivate && modelData.secondaryActivate()
                        } else if (mouse.button === Qt.RightButton) {
                          trayTooltip.hide()
 
-                         // Don't open menu if screen is invalid
-                         if (!screen || !screen.name) {
-                           Logger.warn("Tray", "Cannot open tray menu: invalid screen object")
+                         // Close the menu if it was visible
+                         if (trayPanel && trayPanel.visible) {
+                           trayPanel.close()
                            return
                          }
 
-                         if (modelData.hasMenu && modelData.menu) {
-                           // Get the tray menu panel from PanelService
-                           var trayMenuPanel = PanelService.getPanel("trayMenu")
-                           if (trayMenuPanel) {
-                             trayMenuPanel.menu = modelData.menu
-                             trayMenuPanel.toggle(screen, this)
-                           } else {
-                             Logger.warn("Tray", "Tray menu panel not found")
-                           }
+                         if (modelData.hasMenu && modelData.menu && trayMenu.item) {
+                           trayPanel.open()
+
+                           // Anchor the menu to the tray icon item (parent) and position it below the icon
+                           const menuX = (width / 2) - (trayMenu.item.width / 2)
+                           const menuY = (Style.barHeight * scaling)
+                           trayMenu.item.menu = modelData.menu
+                           trayMenu.item.showAt(parent, menuX, menuY)
                          } else {
-                           Logger.log("Tray", "No menu available for", modelData.id)
+                           Logger.log("Tray", "No menu available for", modelData.id, "or trayMenu not set")
                          }
                        }
                      }
@@ -132,4 +125,43 @@ Rectangle {
       }
     }
   }
+
+  PanelWindow {
+    id: trayPanel
+    anchors.top: true
+    anchors.left: true
+    anchors.right: true
+    anchors.bottom: true
+    visible: false
+    color: Color.transparent
+    screen: screen
+
+    function open() {
+      visible = true
+
+      PanelService.willOpenPanel(trayPanel)
+    }
+
+    function close() {
+      visible = false
+      trayMenu.item.hideMenu()
+    }
+
+    // Clicking outside of the rectangle to close
+    MouseArea {
+      anchors.fill: parent
+      onClicked: trayPanel.close()
+    }
+
+    Loader {
+      id: trayMenu
+      source: "../Extras/TrayMenu.qml"
+
+      onLoaded: {
+        if (item) {
+          item.screen = screen
+        }
+      }
+    }
+  }
 }