never/noctalia-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WallPaperPanel/Selector: added LazyLoader and a smooth animation to reveal images once loaded (#78)

Browse source 
Co-authored-by: Sébastien Atoch <sebastien@atracktiv.com>
This commit is contained in:
Quadbyte 2025-08-03 11:12:07 -04:00 • committed by GitHub
parent 1175ebd485
commit 186fb315dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Widgets/Sidebar/Panel/PanelPopup.qml
View file

@ -59,8 +59,8 @@ PanelWithOverlay {
if (sidebarPopupRect.settingsModal && sidebarPopupRect.settingsModal.visible) { if (sidebarPopupRect.settingsModal && sidebarPopupRect.settingsModal.visible) {
sidebarPopupRect.settingsModal.visible = false; sidebarPopupRect.settingsModal.visible = false;
} }
if (sidebarPopupRect.wallpaperPanelModal && sidebarPopupRect.wallpaperPanelModal.visible) { if (wallpaperPanelLoader && wallpaperPanelLoader.active) {
sidebarPopupRect.wallpaperPanelModal.visible = false; wallpaperPanelLoader.active = false;
} }
if (sidebarPopupRect.wifiPanelModal && sidebarPopupRect.wifiPanelModal.visible) { if (sidebarPopupRect.wifiPanelModal && sidebarPopupRect.wifiPanelModal.visible) {
sidebarPopupRect.wifiPanelModal.visible = false; sidebarPopupRect.wifiPanelModal.visible = false;
@ -125,7 +125,6 @@ PanelWithOverlay {
} }
property alias settingsModal: settingsModal property alias settingsModal: settingsModal
property alias wallpaperPanelModal: wallpaperPanelModal
property alias wifiPanelModal: wifiPanel.panel property alias wifiPanelModal: wifiPanel.panel
property alias bluetoothPanelModal: bluetoothPanel.panel property alias bluetoothPanelModal: bluetoothPanel.panel
SettingsModal { SettingsModal {
@ -313,9 +312,7 @@ PanelWithOverlay {
onSettingsRequested: { onSettingsRequested: {
settingsModal.visible = true; settingsModal.visible = true;
} }
onWallpaperRequested: { onWallpaperRequested: wallpaperPanelLoader.active = true;
wallpaperPanelModal.visible = true;
}
} }
} }
Keys.onEscapePressed: sidebarPopupRect.hidePopup() Keys.onEscapePressed: sidebarPopupRect.hidePopup()
@ -402,16 +399,20 @@ PanelWithOverlay {
} }
} }
LazyLoader {
id: wallpaperPanelLoader
loading: false
WallpaperPanel { WallpaperPanel {
id: wallpaperPanelModal // Need to keep this visible so it shows once loaded
visible: false visible: true
Component.onCompleted: { Component.onCompleted: {
if (parent) { if (parent) {
wallpaperPanelModal.anchors.top = parent.top; anchors.top = parent.top;
wallpaperPanelModal.anchors.right = parent.right; anchors.right = parent.right;
} }
} }
// Add a close button inside WallpaperPanel.qml for user to close the modal }
} }
} }
} }

17
Widgets/Sidebar/Panel/WallpaperPanel.qml
View file

@ -30,7 +30,7 @@ PanelWindow {
} }
onVisibleChanged: { onVisibleChanged: {
if (wallpaperPanelModal.visible) { if (wallpaperPanelLoader.active) {
wallpapers = WallpaperManager.wallpaperList wallpapers = WallpaperManager.wallpaperList
} else { } else {
wallpapers = [] wallpapers = []
@ -81,7 +81,7 @@ PanelWindow {
id: closeButtonArea id: closeButtonArea
anchors.fill: parent anchors.fill: parent
hoverEnabled: true hoverEnabled: true
onClicked: wallpaperPanelModal.visible = false onClicked: wallpaperPanelLoader.active = false;
cursorShape: Qt.PointingHandCursor cursorShape: Qt.PointingHandCursor
} }
} }
@ -136,13 +136,24 @@ PanelWindow {
source: modelData source: modelData
fillMode: Image.PreserveAspectCrop fillMode: Image.PreserveAspectCrop
asynchronous: true asynchronous: true
cache: true cache: false
smooth: true smooth: true
mipmap: true mipmap: true
// Limit memory usage // Limit memory usage
sourceSize.width: 480 sourceSize.width: 480
sourceSize.height: 270 sourceSize.height: 270
} }
Rectangle {
anchors.fill: parent
color: Theme.textPrimary
opacity: (wallpaperImage.status == Image.Ready) ? 0.0 : 1.0
Behavior on opacity {
NumberAnimation {
duration: 500
easing.type: Easing.OutCubic
}
}
}
MouseArea { MouseArea {
anchors.fill: parent anchors.fill: parent
hoverEnabled: true hoverEnabled: true