From dd757c2114c20fa654cffb8ff943ee9c10a5336e Mon Sep 17 00:00:00 2001 From: Kainoa Kanter Date: Fri, 5 Sep 2025 10:26:46 -0700 Subject: [PATCH 1/2] refactor: consistent click behavior for volume & mic bar widgets - left click: open audio settings panel (unchanged) - right click: toggle mute - middle click: pwvucontrol --- Modules/Bar/Widgets/Microphone.qml | 9 +++------ Modules/Bar/Widgets/Volume.qml | 11 ++++------- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/Modules/Bar/Widgets/Microphone.qml b/Modules/Bar/Widgets/Microphone.qml index 5aa7ba9..410e041 100644 --- a/Modules/Bar/Widgets/Microphone.qml +++ b/Modules/Bar/Widgets/Microphone.qml @@ -99,11 +99,8 @@ Item { onRightClicked: { AudioService.setInputMuted(!AudioService.inputMuted) } - } - - Process { - id: pwvucontrolProcess - command: ["pwvucontrol"] - running: false + onMiddleClicked: { + Quickshell.execDetached(["pwvucontrol"]); + } } } diff --git a/Modules/Bar/Widgets/Volume.qml b/Modules/Bar/Widgets/Volume.qml index 9d98eea..5569edc 100644 --- a/Modules/Bar/Widgets/Volume.qml +++ b/Modules/Bar/Widgets/Volume.qml @@ -82,13 +82,10 @@ Item { settingsPanel.open(screen) } onRightClicked: { - pwvucontrolProcess.running = true + AudioService.setMuted(!AudioService.muted) + } + onMiddleClicked: { + Quickshell.execDetached(["pwvucontrol"]); } } - - Process { - id: pwvucontrolProcess - command: ["pwvucontrol"] - running: false - } } From b78708071517c5a7006220987063853058d4d53d Mon Sep 17 00:00:00 2001 From: Kainoa Kanter Date: Fri, 5 Sep 2025 10:28:57 -0700 Subject: [PATCH 2/2] consistent tooltip --- Modules/Bar/Widgets/Volume.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/Bar/Widgets/Volume.qml b/Modules/Bar/Widgets/Volume.qml index 5569edc..5f70998 100644 --- a/Modules/Bar/Widgets/Volume.qml +++ b/Modules/Bar/Widgets/Volume.qml @@ -64,7 +64,7 @@ Item { autoHide: false // Important to be false so we can hover as long as we want text: Math.floor(AudioService.volume * 100) + "%" tooltipText: "Volume: " + Math.round( - AudioService.volume * 100) + "%\nLeft click for advanced settings.\nScroll up/down to change volume." + AudioService.volume * 100) + "%\nLeft click for advanced settings.\nScroll up/down to change volume.\nRight click to toggle mute." onWheel: function (delta) { wheelAccumulator += delta